chore: remove npmrc cleanup in release script #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the cleanup of the .npmrc file from the release script's finally block to fix a bug introduced in a previous pull request.
- Removes the
fs.removeSync(npmrcPath)call from the finally block in the release script
Comments suppressed due to low confidence (1)
scripts/release.mjs:39
- Removing the cleanup of the .npmrc file may leave temporary files on the system. Consider whether this file should be cleaned up elsewhere in the script or if there's a specific reason it needs to persist after the release process.
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that was introduced in #45